Skip to content

Android emulator detection, and a few test fixes #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Dec 2, 2022
Merged

Android emulator detection, and a few test fixes #1150

merged 28 commits into from
Dec 2, 2022

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Nov 21, 2022 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Added the ability to detect running on Android emulator. This is needed because a number of tests misbehave on late-model Android emulators (especially running on ARM); we now skip those tests on Android emulator via a new macro SKIP_TEST_ON_ANDROID_EMULATOR.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Integration test run in this PR on expanded matrix.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Nov 21, 2022
@github-actions
Copy link

github-actions bot commented Nov 21, 2022 •
edited
Loading

❌  Integration test FAILED

Requested by @jonsimantov on commit 2c44e8b
Last updated: Thu Dec 1 20:41 PST 2022
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
functions [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
gma [BUILD] [ERROR] [Windows] [x64] [openssl]
[TEST] [FAILURE] [iOS] [macos] [1/2 ios_device: ios_target]
(2 failed tests)  FirebaseGmaTest.TestRewardedAdLoad
  FirebaseGmaTest.TestRewardedAdLoadEmptyRequest
[TEST] [FLAKINESS] [Android] [2/3 os: macos windows] [1/2 android_device: android_target]
(1 failed tests)  FirebaseGmaTest.TestRewardedAdStress
messaging [TEST] [FLAKINESS] [Android] [2/3 os: macos ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Nov 22, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Nov 22, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Nov 22, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Nov 22, 2022
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Nov 23, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Nov 23, 2022
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Nov 23, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Nov 23, 2022
@jonsimantov jonsimantov changed the title Android emulator detection Android emulator detection, and a few test fixes Nov 23, 2022
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Nov 23, 2022
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Nov 23, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Nov 23, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: failed This PR's integration tests failed. labels Dec 1, 2022
@jonsimantov jonsimantov marked this pull request as ready for review December 1, 2022 19:15
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Dec 1, 2022
@github-actions github-actions bot added tests: succeeded This PR's integration tests succeeded. and removed tests: failed This PR's integration tests failed. labels Dec 1, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 1, 2022
@jonsimantov jonsimantov enabled auto-merge (squash) December 2, 2022 01:34
@jonsimantov jonsimantov merged commit 2c44e8b into main Dec 2, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Dec 2, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 2, 2022
@firebase firebase locked and limited conversation to collaborators Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a-maurice a-maurice a-maurice approved these changes

Assignees

@a-maurice a-maurice

Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @a-maurice